rename GEOSldas_GridComp/Shared to GEOSldas_GridComp/LDAS_Shared #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mathomp4, does this look right to you? If so, please go ahead and merge, or let us know if more tests are needed. Thanks! |
mathomp4
approved these changes
Feb 16, 2024
@gmao-rreichle Looks good to me. Since it's a CMake change, if it builds, it's usually safe. I've approved. If you are ready, feel free to undraft and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the GEOSldas_GridComp/Shared directory to GEOSldas_GridComp/**LDAS_**Shared in anticipation of the GEOSldas restructuring that is necessary for its integration into GEOSadas as external repo(s).
PR was tested successfully with Intel and GNU (LDAS_CONUS and LDAS_GNUCONUS)