Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some GitHub Actions versions #739

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Update some GitHub Actions versions #739

merged 1 commit into from
Mar 21, 2024

Conversation

mathomp4
Copy link
Member

Was doing some comparing and found that GEOSldas was still using checkout@v3 in some GitHub Actions. The latest version is v4 so we move to use that.

If the CI works, it's good code, if it doesn't it's bad code. GEOSldas itself doesn't care.

Note: This is not a huge rush to get in.

@mathomp4 mathomp4 added the 0-diff trivial very, very obvious 0-diff change label Mar 21, 2024
@mathomp4 mathomp4 self-assigned this Mar 21, 2024
@mathomp4 mathomp4 requested review from a team as code owners March 21, 2024 11:41
gmao-rreichle
gmao-rreichle approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. Probably best to merge immediately, so it'll be capture in the release I'm about to create.

@mathomp4 mathomp4 merged commit 8f83907 into develop Mar 21, 2024
7 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/ci-update branch March 21, 2024 18:24
@mathomp4
Copy link
Member Author

Fine by me. Probably best to merge immediately, so it'll be capture in the release I'm about to create.

I pressed the merge button!

@gmao-rreichle gmao-rreichle mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

@gmao-rreichle gmao-rreichle gmao-rreichle approved these changes

Assignees

@mathomp4 mathomp4

Labels
0-diff trivial very, very obvious 0-diff change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathomp4 @tclune @gmao-rreichle