merge BRIDGE into main in preparation for release v1.0.2 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, GEOSgcm_GridComp is cloned via mepo under GEOSldas_GridComp (which echoes how it was in in GEOSldas v17 and older). This PR moves GEOSgcm_GridComp under Components in GEOSldas. This makes its location consistent with GEOSgcm and GEOSldas. Note that this PR requires a corresponding change in the XXX repo:
Remove `GEOSgcm_GridComp` references in `.gitignore`
biljanaorescanin
previously approved these changes
Apr 12, 2024
|
@mathomp4 For some reason we have errors in build here |
Yeah. I need to fix/change some stuff in the LDAS CI. You guys do things in a way that can break my CI. Give me a bit to puzzle over this. |
weiyuan-jiang
previously approved these changes
Apr 12, 2024
... again, after additional changes on develop
gmao-rreichle
dismissed stale reviews from weiyuan-jiang and biljanaorescanin
via
5b6c686
biljanaorescanin
approved these changes
Apr 12, 2024
weiyuan-jiang
approved these changes
Apr 12, 2024
|
Closing this PR because we should be able to go directly from develop to main on GEOSldas_GridComp. There is no need to edit a components.yaml file, as we need to do on the GEOSldas fixture. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.