Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add facility to report apparent (sundial) solar noon from new Orbital system in MAPL #1882

Closed
dr0cloud opened this issue Dec 15, 2022 · 5 comments
Closed

Add facility to report apparent (sundial) solar noon from new Orbital system in MAPL #1882

dr0cloud opened this issue Dec 15, 2022 · 5 comments
Assignees
@mathomp4 @dr0cloud @adarmenov
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) ⌛ Long Term Long term issues

Comments

@dr0cloud
Copy link
Contributor

dr0cloud commented Dec 15, 2022 •
edited
Loading

Add the facility to report apparent (sundial) solar noon from new orbital system for a given day and set of latitudes. This is different from mean solar noon due to the Equation of Time. This diagnostic will be akin to the calculation of the day-length from the diagnostic routine MAPL_SunGetDaylightDuration() and will either be implemented as a separate diagnostic subroutine or perhaps as an optional output from the above routine. Should be zero-diff ... just providing a new diagnostic.
@dr0cloud dr0cloud added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Dec 15, 2022
@dr0cloud
Copy link
Contributor Author

I'm reviewing my notes on the orbital calculations ... its been a while since I developed the new orbital system!

@tclune
Copy link
Collaborator

tclune commented Dec 15, 2022

Recently discovered that my EoT for GISS modelE accidentally assumed solar longitude and obliquity were in radians, while the parameters are actually in degrees. Not used for Earth scenarios, so it went unnoticed for a while.

@dr0cloud dr0cloud changed the title Add facility to report exact time of actual solar noon from new Orbital system in MAPL Add facility to report apparent (sundial) solar noon from new Orbital system in MAPL Dec 15, 2022
@dr0cloud
Copy link
Contributor Author

Welcome Tom to this wee orbital excursion!

dr0cloud added a commit that referenced this issue Jan 4, 2023
@dr0cloud
Merge pull request #1900 from GEOS-ESM/feature/adarmenov/#1882-add-so…
ebb5f16 
…lar-noon-diagnostic

Update MAPL_sun_uc.F90
@dr0cloud dr0cloud mentioned this issue Jan 9, 2023
Merged
7 tasks
tclune added a commit that referenced this issue Jan 9, 2023
@tclune
Merge branch 'develop' into feature/pnorris/#1882-add-solar-noon-diag…
3200046 
…nostic
mathomp4 added a commit that referenced this issue Jan 9, 2023
@mathomp4
Merge pull request #1913 from GEOS-ESM/feature/pnorris/#1882-add-sola…
3e22be5 
…r-noon-diagnostic

Feature/pnorris/#1882 add local solar hour angle diagnostic
@stale
Copy link

stale bot commented Feb 14, 2023

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days, it will be closed. You can add the "long term" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the ❄️ Stale This issue has been marked stale label Feb 14, 2023
@mathomp4 mathomp4 added the ⌛ Long Term Long term issues label Feb 14, 2023
@stale stale bot removed the ❄️ Stale This issue has been marked stale label Feb 14, 2023
@mathomp4
Copy link
Member

Actually, we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathomp4 mathomp4

@dr0cloud dr0cloud

@adarmenov adarmenov

Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) ⌛ Long Term Long term issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mathomp4 @tclune @dr0cloud @adarmenov