Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MAPL_sun_uc.F90 #1900

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Update MAPL_sun_uc.F90 #1900

merged 1 commit into from
Jan 4, 2023

Conversation

adarmenov
Copy link
Contributor

Description

Correct the type of the local solar hour angle (LSHA) argument.

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@adarmenov
Update MAPL_sun_uc.F90
e3eab8e 
Correct the type of the local solar hour angle (LSHA) argument.
@adarmenov adarmenov requested a review from a team as a code owner January 4, 2023 20:43
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Found:

@adarmenov adarmenov requested review from dr0cloud and removed request for a team January 4, 2023 20:43
@adarmenov adarmenov assigned adarmenov and unassigned adarmenov Jan 4, 2023
dr0cloud
dr0cloud approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@dr0cloud dr0cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing a stupid bug I made!

@dr0cloud dr0cloud merged commit ebb5f16 into feature/pnorris/#1882-add-solar-noon-diagnostic Jan 4, 2023
@dr0cloud dr0cloud deleted the feature/adarmenov/#1882-add-solar-noon-diagnostic branch January 4, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr0cloud dr0cloud dr0cloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adarmenov @dr0cloud