Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate _VERIFY in HistoryGridComp #1952

Closed
tclune opened this issue Feb 2, 2023 · 1 comment · Fixed by #1953
Closed

Eliminate _VERIFY in HistoryGridComp #1952

tclune opened this issue Feb 2, 2023 · 1 comment · Fixed by #1953
Assignees
@mathomp4
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) ❗ High Priority This is a high priority PR 🛠️ Refactor This is code refactoring

Comments

@tclune
Copy link
Collaborator

tclune commented Feb 2, 2023

A quick fix is needed to clean History (slightly) prior to some new changes that @metdyn will be implementing. @mathomp4 is the master of carefully using global replace to get this sort of thing right.
@tclune tclune added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 🛠️ Refactor This is code refactoring ❗ High Priority This is a high priority PR labels Feb 2, 2023
@mathomp4
Copy link
Member

mathomp4 commented Feb 2, 2023

@tclune So, go to pure _RC? Or don't verify at all?

mathomp4 added a commit that referenced this issue Feb 2, 2023
@mathomp4
Fixes #1952. Remove _VERIFY from History GC
5611f58
@mathomp4 mathomp4 mentioned this issue Feb 2, 2023
Merged
7 tasks
@mathomp4 mathomp4 linked a pull request Feb 3, 2023 that will close this issue
Fixes #1952. Remove _VERIFY from History GC #1953
Merged
7 tasks
mathomp4 added a commit that referenced this issue Feb 13, 2023
@mathomp4
Merge pull request #1953 from GEOS-ESM/feature/mathomp4/1952-refactor…
4b0d4a3 
…-verify-history

Fixes #1952. Remove _VERIFY from History GC
@github-actions github-actions bot mentioned this issue Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathomp4 mathomp4

Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) ❗ High Priority This is a high priority PR 🛠️ Refactor This is code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1952. Remove _VERIFY from History GC GEOS-ESM/MAPL
2 participants
@mathomp4 @tclune