Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1952. Remove _VERIFY from History GC #1953

Merged
merged 9 commits into from
Feb 13, 2023
Merged

Fixes #1952. Remove _VERIFY from History GC #1953

merged 9 commits into from
Feb 13, 2023

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Feb 2, 2023

Description

This PR removes most of the _VERIFY(STATUS) calls in History. Not all, but most.

Related Issue

closes #1952

Motivation and Context

Makes history cleaner. Removes about 500 lines or so of code.

How Has This Been Tested?

Not at all. Keeping draft until I can test with GEOSgcm

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 2, 2023
@mathomp4 mathomp4 self-assigned this Feb 2, 2023
@mathomp4 mathomp4 marked this pull request as ready for review February 3, 2023 19:37
@mathomp4 mathomp4 requested a review from a team as a code owner February 3, 2023 19:37
@mathomp4 mathomp4 linked an issue Feb 3, 2023 that may be closed by this pull request
Eliminate _VERIFY in HistoryGridComp #1952
Closed
tclune
tclune approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Painful! But thanks!

@mathomp4 mathomp4 merged commit 4b0d4a3 into develop Feb 13, 2023
@mathomp4 mathomp4 deleted the feature/mathomp4/1952-refactor-verify-history branch February 13, 2023 20:20
This was referenced Mar 1, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate _VERIFY in HistoryGridComp
2 participants
@mathomp4 @tclune