Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when using monthly history output #1997

Closed
mathomp4 opened this issue Mar 1, 2023 · 0 comments · Fixed by #1998
Closed

Bug when using monthly history output #1997

mathomp4 opened this issue Mar 1, 2023 · 0 comments · Fixed by #1998
Assignees
Labels
🪲 Bug Something isn't working

Comments

@mathomp4
Copy link
Member

mathomp4 commented Mar 1, 2023

The PR to try and update GEOSgcm to v2.35.0 showed a run-time bug when running a monthly history:

 DEBUG: monthly averaging is active for collection tavg2d_aer_x
 DEBUG: monthly averaging is active for collection tavg3d_aer_p
 
 STUBBED in CPL ReadRestart
pe=00000 FAIL at line=02235    MAPL_HistoryGridComp.F90                 <status=21>
pe=00002 FAIL at line=02235    MAPL_HistoryGridComp.F90                 <status=21>
pe=00000 FAIL at line=01818    MAPL_Generic.F90                         <status=21>
pe=00000 FAIL at line=00703    MAPL_CapGridComp.F90                     <status=21>
pe=00000 FAIL at line=00648    MAPL_CapGridComp.F90                     <status=21>
pe=00000 FAIL at line=00949    MAPL_CapGridComp.F90                     <status=21>
pe=00000 FAIL at line=00299    MAPL_Cap.F90                             <status=21>
pe=00000 FAIL at line=00258    MAPL_Cap.F90                             <status=21>

I didn't catch this before because I always run GEOS with non-monthly history as I only run a day. As such, I missed this. The fix is pretty obvious after looking at this:

5611f58#diff-0c9f15d29823f78a5dbd243a38a4d15479631b4143b114eba4bcbc095255b353

and it's a mistake on my part from #1953

@mathomp4 mathomp4 added the 🪲 Bug Something isn't working label Mar 1, 2023
@mathomp4 mathomp4 self-assigned this Mar 1, 2023
mathomp4 added a commit that referenced this issue Mar 2, 2023
…lyhistory

Fixes #1997. Fix issue with monthly history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant