Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct values in the halo corner of LatLon grid #1911

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

weiyuan-jiang
Copy link
Contributor

The corner values of halo region of latlon grid are filled.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Jan 9, 2023
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner January 9, 2023 14:15
@weiyuan-jiang
Copy link
Contributor Author

It should be non-zero diff. But we don't have such tests so I tag it with zero-diff

@mathomp4
Copy link
Member

mathomp4 commented Jan 9, 2023

It should be non-zero diff. But we don't have such tests so I tag it with zero-diff

@weiyuan-jiang What do you mean it's non-zero-diff but we can't test it? Is it because we can't run with the lat-lon grid?

@weiyuan-jiang
Copy link
Contributor Author

It should be non-zero diff. But we don't have such tests so I tag it with zero-diff

@weiyuan-jiang What do you mean it's non-zero-diff but we can't test it? Is it because we can't run with the lat-lon grid?

I mean we don't have test of halo of latlon and we have not used it . So we cannot see the non-zero-diff

@mathomp4
Copy link
Member

mathomp4 commented Jan 9, 2023

I mean we don't have test of halo of latlon and we have not used it . So we cannot see the non-zero-diff

Ah. Okay. I'll update the branch and get it in.

@mathomp4 mathomp4 merged commit 8ac4f06 into develop Jan 9, 2023
@mathomp4 mathomp4 deleted the bugfix/wjiang/halo_corner branch January 9, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants