Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup more MAPL Intel Debug Messages #2346

Merged
merged 9 commits into from
Sep 18, 2023

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Sep 8, 2023

Description

This PR cleans up more messages from Intel when building with Debug. Removed a lot unused variables, added some _UNUSED_DUMMY and converted some statement functions to internal functions.

Also, update ESMA_cmake to v3.34.0 to get new NAG flags from @tclune

Related Issue

Motivation and Context

Makes the build cleaner!

How Has This Been Tested?

Did a run of GEOS and it was zero-diff.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Sep 8, 2023
@mathomp4 mathomp4 self-assigned this Sep 8, 2023
@mathomp4
Copy link
Member Author

mathomp4 commented Sep 8, 2023

Confirmed zero-diff.

@mathomp4 mathomp4 marked this pull request as ready for review September 8, 2023 16:44
@mathomp4 mathomp4 requested review from a team as code owners September 8, 2023 16:44
@mathomp4 mathomp4 merged commit 51320e8 into develop Sep 18, 2023
25 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/more-cleanup-mapl branch September 18, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants