-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trajectory sampler to ingest multiple IODA files via one route handle #2353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of items that need to be addressed immediately (see inline comments). A couple of others that can be addressed later.
The initial description of this PR would probably make a better entry in the CHANGELOG than what is there now. |
# Conflicts: # base/Plain_netCDF_Time.F90 # gridcomps/History/MAPL_HistoryTrajectoryMod_smod.F90
Aww nuts. I think my cleanup from #2346 touched a couple files that @metdyn did when I did an "update branch":
So, I resolved the conflicts by assuming what @metdyn had is the correct code. This might mean some cleanup was lost, but that's safer. @metdyn Can you pull your branch and test to make sure everything is still working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving and I have tested it and seems to be zero-diff (I'm guessing we don't use any of this in regular GCM work)
Description
The trajectory sampler code originally written by @bena-nasa to regrid to flight trajectory is extended to ingest and regrid to multiple IODA file locations. The implementation mainly have followed #2144. The listed items therein, except for the item-8: related to 3D height interpolation, have been finished in this PR.
The important features include:
The drawback is the original aircraft trajectory functionality is disabled, as the code is tuned for IODA files format.
Note:
Input:
Output: *.geovals.20190801_0300z.nc4 etc.
How Has This Been Tested?
Tested regridding the synthetic data from C720 to 29-IODA files spanning 12 hr time period (from 2019-07-31T21Z). Run finishes in 8 min with 6-cores. Previous experience shows when synthetic data runs can succeed through ExtDataDriver.x, the G5NR run can finish without error.
Types of changes
Checklist: