-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates for geostationary output part 1 #2528
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bena-nasa
added
🎁 New Feature
This is a new feature
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
labels
Jan 12, 2024
Thank you, @bena-nasa, for your work! The code is working with the lambert_grid on the Mac and I am proceeding based on your PR. |
tclune
reviewed
Jan 12, 2024
tclune
reviewed
Jan 12, 2024
tclune
reviewed
Jan 12, 2024
tclune
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice implementation and description.
A couple of small "suggested changes", and a bigger "something to think about".
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
tclune
approved these changes
Jan 16, 2024
tclune
approved these changes
Jan 17, 2024
tclune
changed the title
updates for geostitionary output part 1
updates for geostationary output part 1
Jan 17, 2024
tclune
approved these changes
Jan 17, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
🎁 New Feature
This is a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amdasilva requested that History be able to output geostationary data. This can be described via rectilinear grid with some missing points. We can trivially extend the XY grid factory (which was as generic factory for arbitrary creation of rectilinear grids from a file) for this.
For part 1 this PR will assume the user has converted them to a form that the XY grid factory understands
I tested by obtaining the coordintes (lats and Lons on the sphere) for GOES-16 here
https://www.star.nesdis.noaa.gov/atmospheric-composition-training/satellite_data_goes_imager_projection.php
and converting to the form needed by XY factory (dimensions must be Xdim and Ydim, and will have lons(Xdim,Ydim), lats(Xdim,Ydim)).
The new features are thus
From here @metdyn can extend the grid factory to support the input format @amdasilva showed us if required that requires converting from raw satellite angle inputs via some geometry to lats and Lons on the sphere which is what we really need.
Finally here's a picture so show that this does work, the heights regridded to goes-16 view using the coordinates I obtained from the link earlier in the PR
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: