these add fractions to the analysis #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dooruk do you have time to chat about this. Not sure what's going on here why this fails. |
Are you asking about the Swell Code testing fail? |
No - this is not failing ... |
|
Is this ready for a review? |
Yes! |
gmao-wgu
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GSIBEC needs info on land/water/ice ... these provide that to GSIBEC. Indeed the lack of passing these fields make the StaticFiles setting for GSIBEC inconsistent w/ the analysis ... this change should change results of Var atmos ... for the better.
This also removes redundancy in the winds fields in the atoms-background (no need for u and v winds on d-grid).
Dependencies
This branch already incorporates the changes in the following two PRs
PR #366
PR #367
So the PRs above should be merged to develop before this present PR.
Impact