-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
these add fractions to the analysis #353
Conversation
@Dooruk do you have time to chat about this. Not sure what's going on here why this fails. |
Are you asking about the Swell Code testing fail? |
No - this is not failing ... |
Is this ready for a review? |
Yes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rtodling there was an issue with the whitespace around some of your YAML changes. I fixed it, all good now.
Description
GSIBEC needs info on land/water/ice ... these provide that to GSIBEC. Indeed the lack of passing these fields make the StaticFiles setting for GSIBEC inconsistent w/ the analysis ... this change should change results of Var atmos ... for the better.
This also removes redundancy in the winds fields in the atoms-background (no need for u and v winds on d-grid).
Dependencies
This branch already incorporates the changes in the following two PRs
PR #366
PR #367
So the PRs above should be merged to develop before this present PR.
Impact