Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reappointment subdecision for installations in bodies #347

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Add Reappointment subdecision for installations in bodies #347

merged 2 commits into from
Oct 12, 2023

Commits on Oct 12, 2023

  1. Add Reappointment subdecision for installations in bodies 

    This adds a new type of organ mutation, a reappointment. This mutation
can be used to "prolong" the membership of a member in an organ. The
subdecision refers to the original installation, just like a discharge.

While a self-reference would have been nice (for consecutive
reappointments), it introduces a lot of compexity due to the added
recursion. As such, `Reappointment`s have a many-to-one relationship
with `Installation`s.

`Reappointment`s are processed before `Discharge`s and `Installation`s.

In the Organ Mutations UI, only the `Lid` function can be directly
reappointed. All other functions can be reappointed by checking the
relevant functions in the model. This means that if a function is NOT
checked it will not be reappointed, this means that a discharge for
this particular function is created.

Some of the JavaScript discharge functionality has been moved into a
separate function to reduce code duplication. On top of that, the
reappointments, discharges, and installations are now also sorted as
such in the UI.
    @tomudding
    tomudding committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    76f6c0f View commit details
    Browse the repository at this point in the history

  2. Fix being able to reappoint functions from other members 

    If there are two or more consecutive reappointments, then the modal
is not cleared. This means that the functions from the previous member
are still present. This can result in the accidental reappointment of
these functions.
    @tomudding
    tomudding committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    0dc2bdb View commit details
    Browse the repository at this point in the history