-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve images on committee pages #711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it's not entirely finished yet.
$config['cover_width'], | ||
$config['cover_height'] | ||
); | ||
var_dump($coverPath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik zie een var_dump
.
'options' => [ | ||
'mimeType' => 'image/png' | ||
'extension' => ['png', 'jpg', 'jpeg', 'bmp', 'tiff'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bmp
. BURN IT WITH FIRE AND MAGNETS!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instructions unclear, made bmp
the only accepted format.
$y = round($y * $size[1]); | ||
$width = round($width * $size[0]); | ||
$height = round($height * $size[1]); | ||
var_dump($width,$height); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var_dump
$image->thumbnailImage($thumbWidth, $thumbHeight); | ||
$image->setimageformat('jpg'); | ||
|
||
//Tempfile is used to generate sha1ot sure this is the best method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads a little uneasy, maybe because spelling errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comment.
No description provided.