Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace static image by leaflet map in about page #663

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Conversation

pgiraud
Copy link

@pgiraud pgiraud commented Sep 27, 2016

Fixes #661.

Initial javascript code from Andy, simplified and factorized.

GeoJSON has also been simplified (precision lowered using https://github.com/jczaplew/geojson-precision).

Since the map cannot be interactive in the printed report, I chose to hide it completely in the pdf.

Demo:
http://wb-thinkhazard.dev.sig.cloud.camptocamp.net/pierre/

@pgiraud
Copy link
Author

pgiraud commented Sep 27, 2016

@stufraser1 In my opinion, it would be really better if the map was dynamic and would reflect the actual data in the database. It would of course require more work but wouldn't need any manual update of the geojson in the future. Let's consider this as a nice-to-have for version 3. ;-)

@pgiraud
Copy link
Author

pgiraud commented Nov 30, 2016

Question from the kickoff meeting:

How to go about updating this as data layers are added to GeoNode?

We should be able to get this information by requesting the ThinkHazard! database and extracting the up-to-date information.
Programming such a feature will however take some time and it has not been scheduled given the initial terms of reference.

@stufraser1
Copy link
Member

stufraser1 commented Dec 1, 2016 via email

@pgiraud pgiraud merged commit 73d949e into master Feb 27, 2017
@pgiraud pgiraud deleted the about_map branch February 27, 2017 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants