Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgade to OSHDB version 0.7.0 #222

Merged
merged 7 commits into from
Jul 28, 2021
Merged

upgade to OSHDB version 0.7.0 #222

merged 7 commits into from
Jul 28, 2021

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Jul 26, 2021

Description

upgrades to OSHDB version 0.7

still to do:

  • look for usages of (now) deprecated methods and replace
  • upgrade test file on Jenkins (CI) to 0.7 db schema
  • check for stuff to update in readme / docs(?)
  • add test file to downloads server and update link in readme

New or changed dependencies

  • upgrade oshdb to 0.7.0
  • add oshdb-api-ignite

Checklist

@tyrasd tyrasd added the dependencies Pull requests that update a dependency file label Jul 26, 2021
@tyrasd
Copy link
Member Author

tyrasd commented Jul 26, 2021

look for usages of (now) deprecated methods and replace

AFAICT, the only remaining places of uses of osmType and osmTag are in InputProcessor.java in code paths which are already deprecated there already (i.e. belonging to the old types/keys/values parameters). I'd not hassle to upgrade those to the new filters.

@tyrasd
Copy link
Member Author

tyrasd commented Jul 26, 2021

check for stuff to update in readme / docs(?)

I haven't found anything relevant in the docs, but the download link for the test file needs to be adjusted in the project readme

@tyrasd tyrasd requested a review from rtroilo July 27, 2021 16:18
Copy link
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thank you.
I just got some questions.

README.md Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@tyrasd tyrasd requested a review from rtroilo July 28, 2021 09:45
@tyrasd tyrasd changed the title 🚧 upgade to OSHDB version 0.7.0 upgade to OSHDB version 0.7.0 Jul 28, 2021
@tyrasd tyrasd merged commit 0965541 into master Jul 28, 2021
@tyrasd tyrasd deleted the oshdb-0.7 branch July 28, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants