Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no config loading if test profile is active #1666

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

takb
Copy link
Contributor

@takb takb commented Jan 31, 2024

Information about the changes

  • Reason for change:

Added a check in the ORSEnvironmentPostProcessor to skip configuration files loading if the "test" profile is active. That way the API tests won't break in the future because of changes to ors-config.yml

@takb takb requested a review from MichaelsJP January 31, 2024 13:09
@github-actions github-actions bot added the fix label Jan 31, 2024
@takb takb enabled auto-merge January 31, 2024 13:09
@github-actions github-actions bot added fix and removed fix labels Jan 31, 2024
Copy link
Member

@MichaelsJP MichaelsJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takb takb merged commit 6458260 into main Jan 31, 2024
18 checks passed
@takb takb deleted the fix/config-loader-test-profile branch January 31, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Awaiting release
Development

Successfully merging this pull request may close these issues.

2 participants