-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: way surface type storage #1794
Commits on May 21, 2024
-
refactor: way surface types as enums
Use enumerations instead of simple integer constants in order to be able to store the surface types internally under different IDs than the corresponding API values.
Configuration menu - View commit details
-
Copy full SHA for 2a85552 - Browse repository at this point
Copy the full SHA 2a85552View commit details -
test: add unit test for way surface storage
Check whether values corresponding to the surface types can be reliably written and retrieved from the storage. The test currently fails because the number of different surface types exceeds the available data type range of 4 bits.
Configuration menu - View commit details
-
Copy full SHA for 5fa4bc6 - Browse repository at this point
Copy the full SHA 5fa4bc6View commit details -
fix: reduce the number of way surface types
Remove some less common and relevant surface types such as "woodchips", or ambiguous ones: "fine gravel" and "cobblestone" in order to be able to encode them as 4-bit values. Note that "woodchips" has never been functional because its original value of 16 exceeds the available data type range of 4 bits.
Configuration menu - View commit details
-
Copy full SHA for 366d795 - Browse repository at this point
Copy the full SHA 366d795View commit details -
refactor: replace chained if-then-else statements by a switch statement
Improves code readability and potentially performance.
Configuration menu - View commit details
-
Copy full SHA for d0ccc4a - Browse repository at this point
Copy the full SHA d0ccc4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c4583a - Browse repository at this point
Copy the full SHA 6c4583aView commit details
Commits on May 22, 2024
-
chore: refrain from using deprecated method
Address issue reported by sonarcloud by replacing calls to `com.graphhopper.storage.Directory#find(java.lang.String)` by `com.graphhopper.storage.Directory#create(java.lang.String)`
Configuration menu - View commit details
-
Copy full SHA for 5ded0a3 - Browse repository at this point
Copy the full SHA 5ded0a3View commit details -
fix: classify ways tagged with
surface=earth
as surface type "Dirt"According to OSM wiki `surface=earth` is a synonym of `surface=dirt` and is used for where surface is exposed earth/soil/dirt but it is not sand or gravel or rock.
Configuration menu - View commit details
-
Copy full SHA for 958c9c6 - Browse repository at this point
Copy the full SHA 958c9c6View commit details -
feat: add surface tag values "unhewn_cobblestone", "bricks" and "brick"
Ways labelled with OSM tag `surface` set to "unhewn_cobblestone", "bricks" or "brick" are classified as surface type "Paving Stones" rather than "Unknown".
Configuration menu - View commit details
-
Copy full SHA for 38973b3 - Browse repository at this point
Copy the full SHA 38973b3View commit details -
feat: add a few less common unpaved surface types
Ways labelled with OSM tag `surface` set to "rock", "rocks", "stone", "shells" or "salt" are classified as surface type "Unpaved" rather than "Unknown".
Configuration menu - View commit details
-
Copy full SHA for 0c33751 - Browse repository at this point
Copy the full SHA 0c33751View commit details -
feat: add surface tag values "chipseal", "bitmac" and "tarmac"
Ways labelled with OSM tag `surface` set to "chipseal", "bitmac" or "tarmac" are classified as surface type "Asphalt" rather than "Unknown". According to OSM wiki most of chipseal and bitmac surfaces are likely tagged as `surface=asphalt`, whereas `surface=tarmac` is often incorrectly used for asphalt/concrete surfaces as actual tarmacadam is very unusual.
Configuration menu - View commit details
-
Copy full SHA for 5b1078e - Browse repository at this point
Copy the full SHA 5b1078eView commit details -
feat: add surface tag value "soil"
Ways labelled with OSM tag `surface` set to "soil" are classified as surface type "Dirt" rather than "Unknown".
Configuration menu - View commit details
-
Copy full SHA for ee86cd3 - Browse repository at this point
Copy the full SHA ee86cd3View commit details -
feat: classify ways tagged with
surface=cement
as surface type "Con……crete" According to OSM wiki `surface=cement` is often used, by mistake, instead of `surface=concrete`.
Configuration menu - View commit details
-
Copy full SHA for db68a9c - Browse repository at this point
Copy the full SHA db68a9cView commit details
Commits on May 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 46c19a5 - Browse repository at this point
Copy the full SHA 46c19a5View commit details
Commits on May 24, 2024
-
fix: do not infer surface type from road type
Road classification doesn't necessarily imply surface. For example, driveways which are supposed to be tagged as `highway=service` + `service=driveway` are in many cases not paved.
Configuration menu - View commit details
-
Copy full SHA for 6dc1ab5 - Browse repository at this point
Copy the full SHA 6dc1ab5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4ea21a - Browse repository at this point
Copy the full SHA c4ea21aView commit details