Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to drag features when the new inferHTMLSubfeatures is false #2099

Closed
abretaud opened this issue Mar 21, 2019 · 1 comment · Fixed by #2100
Closed

Unable to drag features when the new inferHTMLSubfeatures is false #2099

abretaud opened this issue Mar 21, 2019 · 1 comment · Fixed by #2100
Assignees
@abretaud
Projects
Apollo
Milestone
2.4.0

Comments

@abretaud
Copy link
Collaborator

An unexpected consequence of GMOD/jbrowse#1340
When I upload a new gene>mrna>cds/exon gff using the jbrowse upload box, the exons are now displayed correctly, but it's not possible to drag them to the UCA track.
I get this error in the console:


TypeError: block is null

    getEquivalentBlock webpack:///./plugins/WebApollo/js/View/Track/DraggableHTMLFeatures.js?:1032
    handleFeatureDragSetup webpack:///./plugins/WebApollo/js/View/Track/DraggableHTMLFeatures.js?:905
    onFeatureMouseDown webpack:///./plugins/WebApollo/js/View/Track/DraggableHTMLFeatures.js?:760

I'm trying to find a solution, but creating the issue to let you know
@nathandunn nathandunn added this to the 2.4.0 milestone Mar 21, 2019
@abretaud
Copy link
Collaborator Author

Ah yes:
https://github.com/GMOD/Apollo/blob/develop/client/apollo/js/View/Track/DraggableHTMLFeatures.js#L895
https://github.com/GMOD/Apollo/blob/develop/client/apollo/js/View/Track/DraggableHTMLFeatures.js#L968
https://github.com/GMOD/Apollo/blob/develop/client/apollo/js/View/Track/DraggableHTMLFeatures.js#L1092

@nathandunn nathandunn added this to To do in Apollo via automation Mar 21, 2019
@nathandunn nathandunn moved this from To do to In progress in Apollo Mar 21, 2019
@abretaud abretaud mentioned this issue Mar 21, 2019
Merged
abretaud added a commit to abretaud/Apollo that referenced this issue Mar 22, 2019
@abretaud
fix block detection with inferHTMLSubfeatures (fixes GMOD#2099)
75b088a
@abretaud abretaud mentioned this issue Mar 22, 2019
Merged
@ghost ghost assigned abretaud Mar 22, 2019
@ghost ghost added the in progress label Mar 22, 2019
Apollo automation moved this from In progress to Done Mar 22, 2019
nathandunn pushed a commit that referenced this issue Mar 22, 2019
@abretaud @nathandunn
Fix block detection with inferHTMLSubfeatures (fixes #2099) (#2100)
83b050d 
* fix block detection with inferHTMLSubfeatures (fixes #2099)

* stricter check for inferHTMLSubfeatures
@ghost ghost removed the in progress label Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abretaud abretaud

Labels
None yet
Projects
No open projects
Apollo
  
Done
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Fix block detection with inferHTMLSubfeatures (fixes #2099) abretaud/Apollo
2 participants
@abretaud @nathandunn