Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group search box testing #1947

Closed
wants to merge 2 commits into from
Closed

Group search box testing #1947

wants to merge 2 commits into from

Conversation

childers
Copy link
Collaborator

This PR is for the addition of search in the group panel. This should be attributed to our new intern Tony Wu

@tony006469
Copy link

10 10

Compared with the console log of original project, I think the problem may be in the permission section of the GroupPanel Code. (uncheck and unsafe operations)
Because I am not sure if my permission part is correct.
I have used the Web Service API to confirm that there are user, group and organism on my local host.
Besides, I added a new GroupInfoConverter. GroupRestService also has some modifications.
I will continue to find ways to debug, if there is any better way, please let me know.
Thank you so much.

@nathandunn
Copy link
Contributor

@tony006469 I use the devmode, but I'll take a look Permisisons could very well be possible

@nathandunn
Copy link
Contributor

I have a couple of ideas for this: ""The specified display has already been added to this adapter."" having it in master, is helpful though .

@nathandunn
Copy link
Contributor

The problem so far as I can tell is that you are adding the display twice for the dataProvider

@ghost ghost assigned nathandunn Oct 11, 2018
@nathandunn
Copy link
Contributor

I removed some of the errant code (you had stuff specified twice in certain circumstances).

You're going to have to update the API on the GroupController (loadGroups) or create a separate route to support the sorting. You can see the "UserController -> loadUsers()" for clarity.

Note that the server routes specfied in grails are: user/loadUsers call the UserController.groovy class's loadUser() method.

@tony006469
Copy link

Ok, I will try it as you mentioned. Thank you so much.

@nathandunn
Copy link
Contributor

@tony006469
Copy link

Yes, but I am not sure if I use it correctly.

@nathandunn
Copy link
Contributor

nathandunn commented Oct 11, 2018 via email

@nathandunn nathandunn changed the title for nameSearchBox testing Group search box testing Dec 5, 2018
@nathandunn nathandunn modified the milestones: 2.1.1, 2.2.1 Dec 5, 2018
@nathandunn
Copy link
Contributor

Closing this for now. This is the right approach overall. Please let me know if this large of groups is causing a problem.

@nathandunn nathandunn closed this Jan 25, 2019
@ghost ghost removed the ready label Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants