bug in section line parsing of FeatureFile

[tolot27]

About a year ago, someone posted the following problem: possible bug in regex for dsn.

Shortly: GBrowse allows regular expressions in data source name configurations as described in Using Pipes in the GBrowse.conf Data Source Name

Today I run into the same problem. I traced it back to the FeatureFile module of this project and fixed it.

[tolot27]

proposed patch:

diff --git a/lib/Bio/Graphics/FeatureFile.pm b/lib/Bio/Graphics/FeatureFile.pm
index 6ce16f3..002715f 100755
--- a/lib/Bio/Graphics/FeatureFile.pm
+++ b/lib/Bio/Graphics/FeatureFile.pm
@@ -842,7 +842,7 @@ sub _state_transition {
        return 'data'   if $line =~ /^reference\s*=/; # feature-file reference sequence directive

        return 'config' if $line =~ /^\s*$/;                             #empty line
-       return 'config' if $line =~ m/^\[([^\]]+)\]/;                    # section beginning
+       return 'config' if $line =~ m/^\[(.+)\]/;                    # section beginning
        return 'config' if $line =~ m/^[\w:\s]+=/ 
            && $self->{current_config};                                  # configuration line
        return 'config' if $line =~ m/^\s+(.+)/
@@ -870,7 +870,7 @@ sub parse_config_line {
        return 1;
     }

-    elsif (/^\[([^\]]+)\]/) {  # beginning of a configuration section
+    elsif (/^\[(.+)\]/) {  # beginning of a configuration section
        my $label = $1;
        my $cc = $label =~ /^(general|default)$/i ? 'general' : $label;  # normalize
        push @{$self->{types}},$cc unless $cc eq 'general';