Skip to content

Commit

Permalink
squashing compiler warnings; are these because of the assignment (as …
Browse files Browse the repository at this point in the history
…opposed to an equality test) in the if, so the comiler requires the extra parens to make you realize that it might be a typo?
  • Loading branch information
Scott Cain committed Oct 14, 2006
1 parent ed2f2b8 commit 4c9eb16
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions libalign/CAlign.xs
Expand Up @@ -204,17 +204,17 @@ _do_alignment(packname="Bio::Graphics::Browser::CAlign",src,tgt,options=NULL)
if (!SvROK(options) || (SvTYPE(SvRV(options)) != SVt_PVHV))
croak("_do_alignment(): third argument must be a hashref");
optionh = (HV*) SvRV(options);
if (value = hv_fetch(optionh,"match",strlen("match"),0))
if ((value = hv_fetch(optionh,"match",strlen("match"),0)))
matrix.match = SvIV(*value);
if (value = hv_fetch(optionh,"mismatch",strlen("mismatch"),0))
if ((value = hv_fetch(optionh,"mismatch",strlen("mismatch"),0)))
matrix.mismatch = SvIV(*value);
if (value = hv_fetch(optionh,"gap",strlen("gap"),0))
if ((value = hv_fetch(optionh,"gap",strlen("gap"),0)))
matrix.gap = SvIV(*value);
if (value = hv_fetch(optionh,"gap_extend",strlen("gap_extend"),0))
if ((value = hv_fetch(optionh,"gap_extend",strlen("gap_extend"),0)))
matrix.gap_extend = SvIV(*value);
if (value = hv_fetch(optionh,"wildcard_match",strlen("wildcard_match"),0))
if ((value = hv_fetch(optionh,"wildcard_match",strlen("wildcard_match"),0)))
matrix.wcmatch = SvIV(*value);
if (value = hv_fetch(optionh,"wildcard",strlen("wildcard"),0))
if ((value = hv_fetch(optionh,"wildcard",strlen("wildcard"),0)))
matrix.wildcard = *SvPV_nolen(*value);
}

Expand Down

0 comments on commit 4c9eb16

Please sign in to comment.