Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to click "force load" button at high zoom levels in some cases #3158

Closed
cmdcolin opened this issue Aug 23, 2022 · 5 comments
Closed
Labels
enhancement New feature or request

Comments

@cmdcolin
Copy link
Collaborator

When looking at e.g. GWAS data, it may get the feature density is too high error but we want to override that. The jbrowse-plugin-gwas may want to ignore the feature density somehow, but currently, it looks like this

Screenshot from 2022-08-23 15-41-31

@cmdcolin cmdcolin added the enhancement New feature or request label Aug 23, 2022
@cmdcolin
Copy link
Collaborator Author

gwas plugin now always tries to render so less common but could come up in other scenarios

@carolinebridge
Copy link
Contributor

I looked into this for a bit today -- it might be difficult to determine when the container for the alert is "too small" to click the button (unless this is only a thing if you're viewing all regions...I think it might be risky to assume that).

Might consider moving the force load to a universal snackbar alert instead of directly on the track? Or if there's a concern for having those overlap / have multiple in a row for different LGV's perhaps overlay one force load overtop of all the regions (instead of constraining to each region) to have the button / message accessible that way.

@cmdcolin
Copy link
Collaborator Author

it might be difficult to determine when the container for the alert is "too small"

i think we could probably technically make the block "measure itself" using a ref -> ref.getClientBoundingRect().width or similar (there are also maybe fancy css ways like https://stackoverflow.com/questions/12251750/can-media-queries-resize-based-on-a-div-element-instead-of-the-screen but the ref measuring should be fine). then maybe if block is smaller than 500px we just make it a compact version of itself e.g. error or warning text on mouseover or something?

@cmdcolin
Copy link
Collaborator Author

this is a random note but now that blocks are smaller (forced to 800px following #3207), we may not need the "repeater" concept that doubles the error messages

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Nov 2, 2022

this is probably a rare use case. may not be worth spending too much time on it unless it comes up again

@cmdcolin cmdcolin closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants