Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with CRAM file with embedded LGV in create-react-app v4 specifically #3427

Closed
cmdcolin opened this issue Dec 21, 2022 · 1 comment · Fixed by GMOD/cram-js#123
Closed
Labels
bug Something isn't working

Comments

@cmdcolin
Copy link
Collaborator

These two links display the CRAM data differently

https://jbrowse.org/demos/lgv/
https://jbrowse.org/demos/lgv-cra5/

CRA5 - works:

Screenshot from 2022-12-20 21-01-44

CRA4 - glitch:

Screenshot from 2022-12-20 21-01-39

Clicking on the feature with weird softclip, can see that SEQ field is odd and has negative numbers in CIGAR

CRA4 - glitch:

Screenshot from 2022-12-20 21-02-26

CRA5 - works:

Screenshot from 2022-12-20 21-03-05

this bug actually leads to the page crashing in CRA4 in some cases due to an infinite loop in decode read sequence

Screenshot from 2022-12-20 21-06-12

create-react-app v5, nextjs, vanillajs, and vite demos not affected by this bug

@cmdcolin cmdcolin added enhancement New feature or request bug Something isn't working breaking and removed enhancement New feature or request breaking labels Dec 21, 2022
@cmdcolin cmdcolin changed the title Issue with CRAM file with create-react-app v4 specifically Issue with CRAM file with embedded LGV in create-react-app v4 specifically Dec 21, 2022
@cmdcolin
Copy link
Collaborator Author

This issue can actually be git-bisected so that it appears to have been introduced in 0a9370fd65c which coincided with the release of v2.2.0 https://jbrowse.org/jb2/blog/2022/11/04/v2.2.0-release/ which included the typescript-ified version of cram-js #3285

Unclear why that is the cause but is a clue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant