Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to remove punycode warning from jbrowse CLI #4163

Closed
cmdcolin opened this issue Jan 9, 2024 · 1 comment · Fixed by #4318
Closed

Try to remove punycode warning from jbrowse CLI #4163

cmdcolin opened this issue Jan 9, 2024 · 1 comment · Fixed by #4318
Labels
enhancement New feature or request housekeeping needs to be tidied up, is a drag on team performance

Comments

@cmdcolin
Copy link
Collaborator

cmdcolin commented Jan 9, 2024

Node 21+ prints a warning on usage of any jbrowse cli about punycode being deprecated...

@cmdcolin cmdcolin added enhancement New feature or request housekeeping needs to be tidied up, is a drag on team performance labels Jan 9, 2024
@cmdcolin
Copy link
Collaborator Author

this is related to using whatwg-url package which is depended on by node-fetch@2 which is used by jbrowse-cli

it is somewhat difficult to remedy this though

possible options

a) use something other than node-fetch. might be most promising, but might want to retain the proxy support that a user asked for (see fetchWithProxy)
b) use node-fetch@3, but this is pure-esm and is tricky to enable properly
c) use native node.js fetch, shipped in v18, but this does not have integration with proxy-agent (TooTallNate/proxy-agents#239)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request housekeeping needs to be tidied up, is a drag on team performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant