Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement grid bookmark widget #2080

Closed
wants to merge 37 commits into from
Closed

Implement grid bookmark widget #2080

wants to merge 37 commits into from

Commits on Jun 15, 2021

  1. Scaffold grid bookmark widget

    @elliothershberg
    elliothershberg committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    92d82fb View commit details
    Browse the repository at this point in the history

  2. Add bookmark widget to lgv hamburger menu

    @elliothershberg
    elliothershberg committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    0b7114c View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Set up styles

    @elliothershberg
    elliothershberg committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    5ae5563 View commit details
    Browse the repository at this point in the history

  2. Add placeholder table

    @elliothershberg
    elliothershberg committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    37eb8cb View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Render locstring cell as link

    @elliothershberg
    elliothershberg committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    689afff View commit details
    Browse the repository at this point in the history

  2. Make bookmarks observable

    @elliothershberg
    elliothershberg committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    362905b View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Add optional key attribute to MST Region type

    @elliothershberg
    elliothershberg committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    6b3f306 View commit details
    Browse the repository at this point in the history

  2. Pass selected region from rubberband to bookmark

    @elliothershberg
    elliothershberg committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    34de1aa View commit details
    Browse the repository at this point in the history

  3. Render rows of bookmarks from MST model

    @elliothershberg
    elliothershberg committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    fd30e17 View commit details
    Browse the repository at this point in the history

  4. Update MST model, make method for add bookmarks

    @elliothershberg
    elliothershberg committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    b1f2a3b View commit details
    Browse the repository at this point in the history

  5. Convert MST array to JS before passing to datagrid

    @elliothershberg
    elliothershberg committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    b19e90f View commit details
    Browse the repository at this point in the history

  6. Move bookmark array from widget to session model

    @elliothershberg
    elliothershberg committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    1c5ef99 View commit details
    Browse the repository at this point in the history

  7. Use session method on rubberband

    @elliothershberg
    elliothershberg committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    6cf1daf View commit details
    Browse the repository at this point in the history

  8. Render rows from session in bookmark widget

    @elliothershberg
    elliothershberg committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    707d40f View commit details
    Browse the repository at this point in the history

  9. Refactor rubberband

    @elliothershberg
    elliothershberg committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    ebd25ee View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Merge branch 'main' into 157_grid_bookmark_widget

    @elliothershberg
    elliothershberg committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    f92b663 View commit details
    Browse the repository at this point in the history

  2. Update snaps

    @elliothershberg
    elliothershberg committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    f51616a View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Remove key attribute from Region mst model

    @elliothershberg
    elliothershberg committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    dcd47b7 View commit details
    Browse the repository at this point in the history

  2. Implement navigation from links

    @elliothershberg
    elliothershberg committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    4d1c96c View commit details
    Browse the repository at this point in the history

  3. Avoid bookmarking same region twice

    @elliothershberg
    elliothershberg committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    91d85f3 View commit details
    Browse the repository at this point in the history

  4. Update height and width of bookmark widget

    @elliothershberg
    elliothershberg committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    c213b8b View commit details
    Browse the repository at this point in the history

  5. Add column for removing bookmarks

    @elliothershberg
    elliothershberg committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    761421c View commit details
    Browse the repository at this point in the history

  6. Add icon to bookmark option for rubberband

    @elliothershberg
    elliothershberg committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    433958e View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Add menu item to bookmark current region in LGV

    @elliothershberg
    elliothershberg committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    4ab634b View commit details
    Browse the repository at this point in the history

  2. Remove unused exports and theme arg

    @elliothershberg
    elliothershberg committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    a91945f View commit details
    Browse the repository at this point in the history

  3. Add option to download BED or TSV of bookmarks

    @elliothershberg
    elliothershberg committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    c631489 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. Create option to clear all bookmarks

    @elliothershberg
    elliothershberg committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    341471d View commit details
    Browse the repository at this point in the history

  2. Remove unused import

    @elliothershberg
    elliothershberg committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    41bd6a1 View commit details
    Browse the repository at this point in the history

  3. Disable DataGrid row selection on click

    @elliothershberg
    elliothershberg committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    de6195d View commit details
    Browse the repository at this point in the history

  4. Add camera icon for svg export

    @elliothershberg
    elliothershberg committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    c0ad5b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. Add component level tests for bookmark widget

    @elliothershberg
    elliothershberg committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    5c859b0 View commit details
    Browse the repository at this point in the history

  2. Add integration tests for bookmark functionality

    @elliothershberg
    elliothershberg committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    8a8c543 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. Fix region selection in test

    @elliothershberg
    elliothershberg committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    a5c8a44 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Merge branch 'main' into 157_grid_bookmark_widget

    @elliothershberg
    elliothershberg committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    2603d43 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Fix CLI README formatting

    @elliothershberg
    elliothershberg committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    c736f73 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. Make bookmark table more compact

    @elliothershberg
    elliothershberg committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    0cbadd6 View commit details
    Browse the repository at this point in the history

  2. Update render test to use snap

    @elliothershberg
    elliothershberg committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    c3e6574 View commit details
    Browse the repository at this point in the history