Skip to content

Commit

Permalink
Merge pull request #1099 from GMOD/fix_initial_fetch_bam
Browse files Browse the repository at this point in the history
Fix initial fetch bam
  • Loading branch information
rbuels committed Jul 9, 2018
2 parents 87da791 + d44288f commit 1272f21
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
7 changes: 4 additions & 3 deletions release-notes.md
Expand Up @@ -3,9 +3,10 @@
## Minor improvements

* Added support for the CSI index format for VCF and BAM files! This format enables genomes
with chromosomes longer than a gigabase to be used in JBrowse. To enable, use the
`csiUrlTemplate` config to point to the file. Thanks to Keiran Raine and others for
motivating this! (issue #926, pull #1086, @cmdcolin)
with individual chromosomes longer than ~537MB (2^29 bases) to be used in JBrowse. To enable,
use the `csiUrlTemplate` config to point to the file. Thanks to Keiran Raine for initial
report and Nathan S Watson-Haigh for catching a bug in the initial implementation!
(issue #926, pull #1086, @cmdcolin)

* Added a `dontRedispatch` option for GFF3Tabix stores. Example: set `dontRedispatch=region`
if there are `region` biotype features in the GFF that do not have subfeatures which will
Expand Down
2 changes: 2 additions & 0 deletions src/JBrowse/Model/CSIIndex.js
Expand Up @@ -105,6 +105,8 @@ return declare( TabixIndex, {
// the linear index

}

this.minAlignmentVO = this.firstDataLine;
deferred.resolve({ success: true });
},

Expand Down
2 changes: 1 addition & 1 deletion src/JBrowse/Store/SeqFeature/BAM/File.js
Expand Up @@ -86,7 +86,7 @@ var BamFile = declare( null,
// BGZF block, assuming BGZF blocks are no bigger than 64KB.
thisB.data.read(
0,
thisB.minAlignmentVO ? thisB.minAlignmentVO.block + 65535 : null,
thisB.index.minAlignmentVO ? thisB.index.minAlignmentVO.block + 65535 : null,
function(r) {
try {
var uncba;
Expand Down

0 comments on commit 1272f21

Please sign in to comment.