Skip to content

Commit

Permalink
some miscellaneous attempted bugfixes for weirdness in closure-compil…
Browse files Browse the repository at this point in the history
…ed code under firefox
  • Loading branch information
rbuels committed Jan 31, 2013
1 parent d4ff773 commit a5a0c56
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/JBrowse/ConfigAdaptor/AdaptorUtil.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ define( [ 'dojox/lang/functional/object',
else if( typeof conf[x] == 'string' ) {
// compile
var spec = conf[x];
if( /^function\s*\(/.test(spec) && /\}[\s;]*$/.test(spec) ) {
if( /^\s*function\s*\(/.test(spec) && /\}[\s;]*$/.test(spec) ) {
conf[x] = this.evalHook(spec);
}
}
Expand Down
8 changes: 4 additions & 4 deletions src/JBrowse/View/Track/HTMLFeatures.js
Original file line number Diff line number Diff line change
Expand Up @@ -362,9 +362,7 @@ var HTMLFeatures = declare( [ BlockBased, YScaleMixin, ExportMixin, FeatureDetai
else {
// if we have transitioned to viewing features, delete the
// y-scale used for the histograms
if( this.yscale ) {
this._removeYScale();
}
this._removeYScale();
this.fillFeatures( dojo.mixin( {stats: stats}, args ) );
}
}));
Expand Down Expand Up @@ -411,8 +409,10 @@ var HTMLFeatures = declare( [ BlockBased, YScaleMixin, ExportMixin, FeatureDetai
* @private
*/
_removeYScale: function() {
if( !this.yscale )
if( !this.yscale ) {
dojo.query( '.ruler', this.div ).orphan();
return;
}
this.yscale.parentNode.removeChild( this.yscale );
delete this.yscale_params;
delete this.yscale;
Expand Down
2 changes: 1 addition & 1 deletion src/JBrowse/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "JBrowse",
"version": "dev",
"version": "1.8.0",
"main": "main",
"dependencies": {
"dojo": "current",
Expand Down

0 comments on commit a5a0c56

Please sign in to comment.