fwupd: Remove now-unused call to fwupd_device_get_description()

See fwupd/fwupd#6820 for the fwupd half -- which will be present in fwupd 2.0.0 due for release in a couple of months time.
GNOME · Feb 20, 2024 · b4e7899 · b4e7899
1 parent c32038c
commit b4e7899
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 14 deletions.
diff --git a/plugins/fwupd/gs-fwupd-app.c b/plugins/fwupd/gs-fwupd-app.c
@@ -162,16 +162,6 @@ gs_fwupd_app_set_from_device (GsApp *app,
 	}
 	if (fwupd_device_get_created (dev) != 0)
 		gs_app_set_install_date (app, fwupd_device_get_created (dev));
-	if (fwupd_device_get_description (dev) != NULL) {
-		g_autofree gchar *tmp = NULL;
-#if AS_CHECK_VERSION(1, 0, 0)
-		tmp = as_markup_convert (fwupd_device_get_description (dev), AS_MARKUP_KIND_TEXT, NULL);
-#else
-		tmp = as_markup_convert_simple (fwupd_device_get_description (dev), NULL);
-#endif
-		if (tmp != NULL)
-			gs_app_set_description (app, GS_APP_QUALITY_NORMAL, tmp);
-	}
 
 #if FWUPD_CHECK_VERSION(1, 8, 1)
 	if (fwupd_device_get_problems (dev) != FWUPD_DEVICE_PROBLEM_NONE) {

diff --git a/plugins/fwupd/gs-plugin-fwupd.c b/plugins/fwupd/gs-plugin-fwupd.c
@@ -459,7 +459,6 @@ gs_plugin_fwupd_new_app_from_device_raw (GsPlugin *plugin, FwupdDevice *device)
 	gs_app_set_version (app, fwupd_device_get_version (device));
 	gs_app_set_name (app, GS_APP_QUALITY_LOWEST, fwupd_device_get_name (device));
 	gs_app_set_summary (app, GS_APP_QUALITY_LOWEST, fwupd_device_get_summary (device));
-	gs_app_set_description (app, GS_APP_QUALITY_LOWEST, fwupd_device_get_description (device));
 	gs_app_set_origin (app, fwupd_device_get_vendor (device));
 	gs_fwupd_app_set_device_id (app, fwupd_device_get_id (device));
 	gs_app_set_management_plugin (app, plugin);

diff --git a/plugins/fwupd/gs-self-test.c b/plugins/fwupd/gs-self-test.c
@@ -53,9 +53,6 @@ gs_plugins_fwupd_func (GsPluginLoader *plugin_loader)
 	size_download_type = gs_app_get_size_download (app, &size_download_bytes);
 	g_assert_cmpint (size_download_type, ==, GS_SIZE_TYPE_VALID);
 	g_assert_cmpuint (size_download_bytes, ==, 32784);
-	g_assert_cmpstr (gs_app_get_description (app), ==,
-			 "This is the first paragraph in the example "
-			 "cab file.\n\nThis is the second paragraph.");
 #if FWUPD_CHECK_VERSION(1, 7, 1) && !FWUPD_CHECK_VERSION(1, 8, 0)
 	/* Changes introduced in fwupd commit d3706e0e0b0fc210796da839b84ac391f7a251f8 and
 	   removed for 1.8.0 with https://github.com/fwupd/fwupd/commit/0eeaad76ec79562ea3790bb377d847d5be02182f */