Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the almost unused fwupd_device_get_description() #6820

Merged
merged 1 commit into from Feb 19, 2024

Conversation

hughsie
Copy link
Member

@hughsie hughsie commented Feb 19, 2024

Type of pull request:

superm1
superm1 previously approved these changes Feb 19, 2024
@hughsie hughsie force-pushed the hughsie/fwupd_device_set_description branch from 5009b92 to d57401a Compare February 19, 2024 18:43
@hughsie hughsie marked this pull request as ready for review February 19, 2024 19:38
@hughsie hughsie merged commit 940d0c0 into main Feb 19, 2024
20 checks passed
@hughsie hughsie deleted the hughsie/fwupd_device_set_description branch February 19, 2024 19:39
gnomesysadmins pushed a commit to GNOME/gnome-software that referenced this pull request Feb 19, 2024
See fwupd/fwupd#6820 for the fwupd half -- which will
be present in fwupd 2.0.0 due for release in a couple of months time.
gnomesysadmins pushed a commit to GNOME/gnome-software that referenced this pull request Feb 20, 2024
See fwupd/fwupd#6820 for the fwupd half -- which will
be present in fwupd 2.0.0 due for release in a couple of months time.
@pwithnall
Copy link
Collaborator

gnome-software is using this API. Is libfwupd no longer API stable?

@hughsie
Copy link
Member Author

hughsie commented Feb 29, 2024

See https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/1882 -- fwupd git main branch has an ABI bump, but we're planning to maintain 1.9.x as API/ABI stable for a long time yet. There's no ETA on fwupd 2.0.0 at the moment, it's just removing cruft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants