made jhbuild more cross-platform #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added dependency on appdirs from ActiveState which is mit licensed - Query the cache directory through appdirs, which makes that bit cross-platform: no more crash on windows because of this.
|
FYI: nobody looks at these pull requests; you should file bugs on bugzilla.gnome.org |
|
Thank you for contributing to jhbuild! jhbuild uses Bugzilla for code review. If you have never contributed to GNOME before make sure you have read the Otherwise please visit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced some direct os environment variable querying with their equivalent cross-platform solutions.
Added a dependency on appdirs to take care of finding the right caching folder, in a cross-platform way.
Removed some legacy code from the monkeypatch (might need more work).
As a bonus, in the files I worked in, I tried to improved pep8 compliance by cleaning up some simple whitespace issues.