Add Set-Cookie to the set of removed headers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A cache entry should not store the Set-Cookie header, or it could revive an old cookie on a cache hit.
|
Thanks for your contribution to GNOME. This repository is only a mirror and it is not monitored for pull requests. If you would still like your contribution to be considered, please submit it on GNOME Bugzilla. See Newcomers/CodeContributionWorkflow for help with contributing patches. |
|
Thank you for contributing to libsoup! libsoup uses Bugzilla for code review. If you have never contributed to GNOME before make sure you have read the Otherwise please visit |
gnomesysadmins
pushed a commit
that referenced
this pull request
Jun 13, 2018
…parsed text This patch makes the implementation of soup_cookie_parse() match the behaviour described in the API reference documentation, which reads: If origin is NULL, path will default to "/", but domain will be left as NULL. Fixes #1
gnomesysadmins
pushed a commit
that referenced
this pull request
Jun 13, 2018
Set default cookie path when origin is NULL and value not present in parsed text Closes #1 See merge request GNOME/libsoup!5
gnomesysadmins
pushed a commit
that referenced
this pull request
Aug 10, 2018
…parsed text This patch makes the implementation of soup_cookie_parse() match the behaviour described in the API reference documentation, which reads: If origin is NULL, path will default to "/", but domain will be left as NULL. Fixes #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cache entry should not store the Set-Cookie header,
or it could revive an old cookie on a cache hit.