tree: Fix handling of empty strings in xmlNodeParseContent

We shouldn't create an empty text node to match the old behavior. Fixes #759.
GNOME · Jul 3, 2024 · 944cc23 · 944cc23
1 parent 46ec621
commit 944cc23
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/testparser.c b/testparser.c
@@ -13,6 +13,21 @@
 
 #include <string.h>
 
+static int
+testNewDocNode(void) {
+    xmlNodePtr node;
+    int err = 0;
+
+    node = xmlNewDocNode(NULL, NULL, BAD_CAST "c", BAD_CAST "");
+    if (node->children != NULL) {
+        fprintf(stderr, "empty node has children\n");
+        err = 1;
+    }
+    xmlFreeNode(node);
+
+    return err;
+}
+
 static int
 testStandaloneWithEncoding(void) {
     xmlDocPtr doc;
@@ -631,6 +646,7 @@ int
 main(void) {
     int err = 0;
 
+    err |= testNewDocNode();
     err |= testStandaloneWithEncoding();
     err |= testUnsupportedEncoding();
     err |= testNodeGetContent();

diff --git a/tree.c b/tree.c
@@ -1214,7 +1214,7 @@ xmlNodeParseContentInternal(const xmlDoc *doc, xmlNodePtr parent,
     else
         remaining = len;
 
-    if (value == NULL)
+    if ((value == NULL) || (value[0] == 0))
         goto done;
 
     cur = value;