Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Apply" button in the "Preferences" dialog stays gray when templates/nodes are opened by double-click #3307

Closed
andrei-korshikov opened this issue Mar 21, 2022 · 1 comment
Closed

"Apply" button in the "Preferences" dialog stays gray when templates/nodes are opened by double-click #3307

andrei-korshikov opened this issue Mar 21, 2022 · 1 comment
Assignees
@grossmj
Labels
Bug
Milestone
2.2.32

Comments

@andrei-korshikov
Copy link

andrei-korshikov commented Mar 21, 2022 •
edited
Loading

Describe the bug
"Apply" button in the "Preferences" dialog stays gray when templates/nodes are opened by double-click instead of pressing "Edit" button. I believe there are some problems with #3239 implementation.

GNS3 version and operating system:

  • OS: Arch Linux (uname -sr: Linux 5.16.14-zen1-1-zen)
  • GNS3 version: 2.2.31
  • no use of the GNS3 VM or remote server

To Reproduce

  1. Go to "Edit" - "Preferences".
  2. Go to any nodes/templates section (for example, "Qemu VMs").
  3. Double-click on any template.
  4. Change something and press "OK" button in the "template configuration" dialog.
  5. See that "Apply" button of the "Preferences" dialog is gray (at this moment you can press "OK" button, but your changes will not be saved).
  6. Press "Edit" button. Don't change anything.
  7. Close "template configuration" dialog (doesn't matter with "OK" or "Cancel").
  8. See that "Apply" button is now unlocked. And only now you can save your changes with "OK" or "Apply" button of the "Preferences" dialog.
@grossmj grossmj added this to the 2.2.32 milestone Mar 28, 2022
@grossmj grossmj self-assigned this Apr 18, 2022
@grossmj grossmj modified the milestones: 2.2.32, 2.2.33 Apr 20, 2022
grossmj added a commit that referenced this issue Apr 20, 2022
@grossmj
Fix "Apply" button in the "Preferences" dialog stays gray when templa…
6d131a0 
…tes/nodes are opened by double-click. Fixes #3307
@grossmj
Copy link
Member

grossmj commented Apr 20, 2022

Fixed, thanks 👍

@grossmj grossmj closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grossmj grossmj

Labels
Bug
Projects
None yet
Milestone
2.2.32
Development

No branches or pull requests
2 participants
@grossmj @andrei-korshikov