Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Move port list to server #676

Closed
julien-duponchelle opened this issue Sep 13, 2016 · 3 comments
Closed

[2.0] Move port list to server #676

julien-duponchelle opened this issue Sep 13, 2016 · 3 comments
Assignees
@julien-duponchelle
Labels
Enhancement
Milestone
2.0.2

Comments

@julien-duponchelle
Copy link
Contributor

Actually the list of port is computed by the GUI but this mean we need to rewrite everything for the futur web application.

Instead of duplicating all the code we will move everything to a central location in the controller. Making easier to improve port name formating, check of what kind of port could be connected together...

This will help for #654 and GNS3/gns3-gui#1502
@julien-duponchelle julien-duponchelle added this to the 2.0 milestone Sep 13, 2016
@julien-duponchelle julien-duponchelle self-assigned this Sep 13, 2016
@julien-duponchelle julien-duponchelle mentioned this issue Sep 13, 2016
Closed
@julien-duponchelle
Copy link
Contributor Author

I'm on this task to fix it in priority because could break a lot of stuff.

@julien-duponchelle
Copy link
Contributor Author

I will take advantage of this task for implementing port update in the GUI instead of clear all and replace in some nodes.

julien-duponchelle added a commit that referenced this issue Sep 13, 2016
@julien-duponchelle
port name format is a settings for all nodes even if not use all the …
3c7ed40 
…time

Ref #676
julien-duponchelle added a commit that referenced this issue Sep 14, 2016
@julien-duponchelle
port name format is a settings for all nodes even if not use all the …
00d8d7b 
…time

Ref #676
julien-duponchelle added a commit to GNS3/gns3-gui that referenced this issue Sep 14, 2016
@julien-duponchelle
Get port names from server
1bcf669 
Ref #1502, GNS3/gns3-server#676
julien-duponchelle added a commit that referenced this issue Sep 14, 2016
@julien-duponchelle
Move the generation of the list of ports to the server
2f0e226 
Ref #676
@julien-duponchelle
Copy link
Contributor Author

Ok it's done I hope to not introduce bugs. It seem to fix several gui bugs due to issue of sync with server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julien-duponchelle julien-duponchelle

Labels
Enhancement
Projects
None yet
Milestone
2.0.2
Development

No branches or pull requests
1 participant
@julien-duponchelle