Implement toUintXX for 64, 96 and 128 bits #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* (WIP) Upgrade to Solidity v0.5.0 (#21) * (refactor) Changed codebase to Solidity v0.5.0 * Style changes * Added `memory` everywhere to bytes and strings * `target.call(data)` now returns a tuple * Adding note about compiler support in the README + typo fix * Replaced the ThrowProxy pattern for a better v0.5.x one ThrowProxy was giving problems while testing with the JS-VM with the Constantinople hard-fork. So I changed the tests to stop using that pattern and use function selectors since that's now a thing. It is cleaner now. * Update package-lock.json * Bump version to v0.0.7 * Bump version in package-lock.json * Update dependency versions * Fix typo in package-lock.json
|
Just redid some of the bogus data in the tests to match the previous style but other than that LGTM! 😄 Thank you for the contribution @bh2smith! |
|
I just pointed the PR to the |
|
Thanks @GNSPS, I believe the conflicts have been resolved appropriately. Is there a release schedule planned for these changes? |
|
I'm sorry for the delay, @bh2smith!! I'll merge and release right away! 😄 |
|
Released in both EPM and NPM! 😄 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
Test Plan: run
truffle test.