Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for inviteuser and password module #18

Merged
merged 7 commits into from
Aug 15, 2019

Conversation

GOVINDDIXIT
Copy link
Owner

This PR is specific to GSoC'19 project (Improve test automation in Rocket.Chat Android Repo)

Change Log

  • Add UI test inviteUser module
  • Add UI test password module

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #18 into develop will increase coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop     #18      +/-   ##
============================================
+ Coverage       1.45%   1.97%   +0.52%     
+ Complexity        29      28       -1     
============================================
  Files            123      59      -64     
  Lines           4386    3031    -1355     
  Branches         942     682     -260     
============================================
- Hits              64      60       -4     
+ Misses          4303    2955    -1348     
+ Partials          19      16       -3
Impacted Files Coverage Δ Complexity Δ
...username/presentation/RegisterUsernamePresenter.kt 26.19% <0%> (-3.54%) 2% <0%> (ø)
...loginoptions/presentation/LoginOptionsPresenter.kt 4.65% <0%> (-0.12%) 3% <0%> (ø)
...d/chatdetails/presentation/ChatDetailsPresenter.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...at/rocket/android/chatroom/domain/UriInteractor.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...messages/presentation/FavoriteMessagesPresenter.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ouping/presentation/SortingAndGroupingPresenter.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...android/chatroom/presentation/ChatRoomPresenter.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...d/inviteusers/presentation/InviteUsersPresenter.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...atinformation/presentation/MessageInfoPresenter.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...at/rocket/android/members/uimodel/MemberUiModel.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f510e...5dc6522. Read the comment docs.

@GOVINDDIXIT GOVINDDIXIT requested review from ear-dev and removed request for jaytat0 August 11, 2019 20:23
Copy link
Collaborator

@ear-dev ear-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GOVINDDIXIT I ran the two new modules and they passed. The app still crashes due to that upstream issue we discussed, but I can approve this PR and you can merge.

@GOVINDDIXIT GOVINDDIXIT merged commit 06ceaa7 into develop Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants