GPII-2558: Provide an API for the local flow manager to update preferences #585
Conversation
…updating preferences.
|
CI job passed: https://ci.gpii.net/job/universal-tests/682/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/698/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/702/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/708/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/712/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/742/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/750/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/761/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/762/ |
|
The |
| .reply(config.untrustedSettingsGet.status, config.untrustedSettingsGet.response); | ||
|
|
||
| // mock PUT requests to "/untrusted-settings" | ||
| cloudMock.put(config.untrustedSettingsPut.url) |
There was a problem hiding this comment.
Are we able to put a matcher here that verifies the preferences being sent? At the moment these tests do not verify that the preferences are being sent along to the cloud. If I modify gpii/node_modules/flowManager/src/UntrustedSettingsDataSource.js so that an empty object is sent instead of the specified preferences, the tests still pass.
|
CI job passed: https://ci.gpii.net/job/universal-tests/768/ |
|
@simonbates, all comments have been addressed and ready for more reviews. Thanks. |
On the cloud, PUT requests on /untrusted-settings are now supported for updating preferences. This pull request adds the {untrustedSettingsDataSource}.set() API for the local flow manager to make use of this support to interact with the cloud to update preferences.