Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-2558: Provide an API for the local flow manager to update preferences #585

Merged
merged 20 commits into from Mar 19, 2018

Conversation

Projects
None yet
3 participants
@cindyli
Copy link
Contributor

commented Jan 30, 2018

On the cloud, PUT requests on /untrusted-settings are now supported for updating preferences. This pull request adds the {untrustedSettingsDataSource}.set() API for the local flow manager to make use of this support to interact with the cloud to update preferences.

@cindyli cindyli requested a review from simonbates Jan 30, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Jan 30, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Feb 15, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Feb 16, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Feb 20, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Feb 22, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 6, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 8, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2018

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2018

@simonbates

This comment has been minimized.

Copy link
Member

commented Mar 19, 2018

The gpii.tests.untrustedSettingsDataSource.testCaseHolder grade from gpii/node_modules/flowManager/test/UntrustedSettingsDataSourceTests.js is no longer used and can be removed.

.reply(config.untrustedSettingsGet.status, config.untrustedSettingsGet.response);

// mock PUT requests to "/untrusted-settings"
cloudMock.put(config.untrustedSettingsPut.url)

This comment has been minimized.

Copy link
@simonbates

simonbates Mar 19, 2018

Member

Are we able to put a matcher here that verifies the preferences being sent? At the moment these tests do not verify that the preferences are being sent along to the cloud. If I modify gpii/node_modules/flowManager/src/UntrustedSettingsDataSource.js so that an empty object is sent instead of the specified preferences, the tests still pass.

@gpii-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2018

@cindyli

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2018

@simonbates, all comments have been addressed and ready for more reviews. Thanks.

@simonbates simonbates merged commit 16fcf3c into GPII:master Mar 19, 2018

1 check passed

default Build finished.
Details

@cindyli cindyli deleted the cindyli:GPII-2558 branch Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.