Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unifed memory heap being ignored on vulkan #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JMS55
Copy link

@JMS55 JMS55 commented Jan 18, 2023

On my iGPU with 8gb of unifed memory between the CPU and GPU, vkGetPhysicalDeviceMemoryProperties() reports only a single heap. The heap has VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set. This causes BackendContext_VK::findMemoryTypeIndex() to skip the heap. As there are no other heaps, the function returns UINT32_MAX, resulting in failed context creation.

This patch modifies the loop to only skip the heap if at least one satisfactory heap has already been found.

GPU Info:
AdapterInfo { name: "Intel(R) UHD Graphics 620 (KBL GT2)", vendor: 32902, device: 22807, device_type: IntegratedGpu, driver: "Intel open-source Mesa driver", driver_info: "Mesa 22.3.3", backend: Vulkan }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant