Fix unifed memory heap being ignored on vulkan #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my iGPU with 8gb of unifed memory between the CPU and GPU,
vkGetPhysicalDeviceMemoryProperties()
reports only a single heap. The heap hasVK_MEMORY_PROPERTY_HOST_VISIBLE_BIT
set. This causesBackendContext_VK::findMemoryTypeIndex()
to skip the heap. As there are no other heaps, the function returns UINT32_MAX, resulting in failed context creation.This patch modifies the loop to only skip the heap if at least one satisfactory heap has already been found.
GPU Info:
AdapterInfo { name: "Intel(R) UHD Graphics 620 (KBL GT2)", vendor: 32902, device: 22807, device_type: IntegratedGpu, driver: "Intel open-source Mesa driver", driver_info: "Mesa 22.3.3", backend: Vulkan }