Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptomatte AOV enable #165

Merged
merged 0 commits into from Dec 16, 2020
Merged

Cryptomatte AOV enable #165

merged 0 commits into from Dec 16, 2020

Conversation

bsavery
Copy link
Contributor

@bsavery bsavery commented Dec 13, 2020

PURPOSE

To enable Cryptomatte AOVs, a powerful way of creating and selecting certain parts of the render in compositing.
Note. I followed this tutorial of usage in blender compositor: https://www.youtube.com/watch?v=VBJQM-gIob8&ab_channel=FlippedNormals

EFFECT OF CHANGE

Two AOV options are added "Material" and Object Cryptomatte AOVs. Each creates 3 aovs that can be hooked up to the cryptomatte node in the compositor and then allowed to pick whatever objects or material you want

NOTES FOR REVIEWERS

I had to make a separate aovs_info for cryptomatte. Why? Because BoolVector properties can only go to 32 in blender. ;). With the 6 needed for cryptomatte we went over this limit. I suppose I could hack it so that 1 item in the aovs_info list could create more than one aov, but that feels hacky.

Known issues:

The aovs are black on macOS with GPU rendering, ok for CPU.

@bsavery
Copy link
Contributor Author

bsavery commented Dec 13, 2020

Screen Shot 2020-12-12 at 5 08 14 PM

Using this with BMW scene and selecting the wheel

@bnagirniak
Copy link
Contributor

Should we have cryptomate panel in UI or something like this? Where in UI cryptomate should be applied?

@bsavery
Copy link
Contributor Author

bsavery commented Dec 14, 2020

Should we have cryptomate panel in UI or something like this? Where in UI cryptomate should be applied?

I just added aov buttons for it. We could add a separate panel but I don't think it's necessary.

@bnagirniak
Copy link
Contributor

Where are such buttons? Can't find them in view layer properties tab, also can't find such code in code changes.

@bsavery
Copy link
Contributor Author

bsavery commented Dec 15, 2020

Fixed.

Copy link
Contributor

@bnagirniak bnagirniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - it works now. Would be good also to hear some overview from QA team.

Copy link
Contributor

@ardraeiss ardraeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine

@bsavery
Copy link
Contributor Author

bsavery commented Dec 15, 2020

Tested - it works now. Would be good also to hear some overview from QA team.

Will ping them

@ARozghon
Copy link

was checked manually and it's work as expected if compare results with Cycles

@bsavery bsavery merged commit 8b2df61 into develop Dec 16, 2020
@bsavery bsavery deleted the Cryptomatte branch December 16, 2020 23:17
VascoPi pushed a commit to VascoPi/RadeonProRenderBlenderAddon that referenced this pull request Jun 2, 2023
PURPOSE
To enable Cryptomatte AOVs, a powerful way of creating and selecting certain parts of the render in compositing.
Note. I followed this tutorial of usage in blender compositor: https://www.youtube.com/watch?v=VBJQM-gIob8&ab_channel=FlippedNormals

EFFECT OF CHANGE
Two AOV options are added "Material" and Object Cryptomatte AOVs. Each creates 3 aovs that can be hooked up to the cryptomatte node in the compositor and then allowed to pick whatever objects or material you want
VascoPi pushed a commit to VascoPi/RadeonProRenderBlenderAddon that referenced this pull request Jun 8, 2023
PURPOSE
To enable Cryptomatte AOVs, a powerful way of creating and selecting certain parts of the render in compositing.
Note. I followed this tutorial of usage in blender compositor: https://www.youtube.com/watch?v=VBJQM-gIob8&ab_channel=FlippedNormals

EFFECT OF CHANGE
Two AOV options are added "Material" and Object Cryptomatte AOVs. Each creates 3 aovs that can be hooked up to the cryptomatte node in the compositor and then allowed to pick whatever objects or material you want
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants