Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for disabling vsync, having access to the compiled spirv src and reflection on ubo members #22

Closed
SilvanVR opened this issue Aug 26, 2018 · 1 comment

Comments

@SilvanVR
Copy link

SilvanVR commented Aug 26, 2018

Hello folks,
first things first: Awesome lib! I love it so far.

1.) VSync
I really need to disable vsync but i really don't want to mess with the vez code myself if i don't have to.
I recognized there is a function "vezDeviceSetVSync", which unfortunately just returns that the feature is not present yet. Could you please add support for it?

2.) Compiling glsl
Because compiling glsl is terrible slow in debug mode with vez (i did it before myself with shaderc, that was WAY faster in debug), i suggest a function like "vezCompileGLSL(device, info, spv)", which returns the compiled spirv-code, so its able to dump it on disk and read it later.

3.) Reflection on ubo members
This is probably a must have. The information for all the uniform buffer members is simply not parsed, only the whole ubo size is computed. It would be nice to have access to all the members names and types in a ubo. SPIRV-Cross supports it and i had it already implemented before i decided to switch using vez instead of doing everything from scratch

All these points shouldn't take to much time for somebody who's familiar with the code.
If you can't afford time for it i will do it myself after i have done everything else, but i'm also very short on time right now. (Writing my Master Thesis)

Thanks and have a great day!
SH

@SilvanVR SilvanVR changed the title Please add support for disabling vsync Please add support for disabling vsync and having access to the compile spirv src Aug 26, 2018
@SilvanVR SilvanVR changed the title Please add support for disabling vsync and having access to the compile spirv src Please add support for disabling vsync and having access to the compiled spirv src Aug 26, 2018
@SilvanVR SilvanVR changed the title Please add support for disabling vsync and having access to the compiled spirv src Please add support for disabling vsync, having access to the compiled spirv src and reflection on ubo buffer members Aug 26, 2018
@SilvanVR SilvanVR changed the title Please add support for disabling vsync, having access to the compiled spirv src and reflection on ubo buffer members Please add support for disabling vsync, having access to the compiled spirv src and reflection on ubo members Aug 26, 2018
@soconne
Copy link
Contributor

soconne commented Aug 27, 2018

  1. Just fixed this with 1f8e9b2

  2. Added a new function called vezGetShaderModuleBinary 0884906. Please keep in mind for offline compilation, its easier to simply use Khronos's glslangValidator tool.

  3. I created a new ticket for this Add reflection support for individual ubo and ssbo members #24

@soconne soconne closed this as completed Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants