Add Feature Flags article #559
Conversation
There was a problem hiding this comment.
This is great stuff.
I left a lengthy commentary on a bullet point where the wording doesn't feel quite right, but ironically couldn't quite get the wording or even main idea of my comment quite right. In any event, it is not particularly important. I left it in case it resonates and leads you to where I couldn't quite get.
Otherwise, feel free to just ignore it. This is a fantastic writeup.
_articles/appdev-feature-flags.md
Outdated
| - **Pros:** | ||
| - This helps ensure broad test coverage for your new feature in continuous integratration (CI) builds. | ||
| - You will want to ensure that a feature flag is enabled in test environments before going live in production, so enabling it early saves a future step. | ||
| - Enabling your new feature by default may cause existing tests to fail where it breaks expectations of how a user proceeds through the application, but this is inevitable and easier to address earlier in the feature development than later. |
There was a problem hiding this comment.
Actually, does this relate to what I'm saying above, too? This bullet point technically starts off with a "Con," but addresses the silver lining. I feel like the point behind both of these is that enabling it in non-prod environments helps spot issues sooner, when they're easier to address.
There was a problem hiding this comment.
Yeah, I see what you're saying here, and I waffled a bit on this too. I tried to rephrase it a bit in c090e92, let me know if that helps make it more readable.
Not strictly necessary to make a code change here Related: #559 (comment)
aduth
dismissed stale reviews from n1zyy, zachmargolis, and mitchellhenke
via
ab2e89c
🛠 Summary of changes
Adds a new article describing the purpose and lifecycle of feature flags in Rails applications.
This was an action item from the 2024-05-29 Engineering Huddle meeting.
📜 Testing Plan