Override GSA-TTS .allstar config for "dismiss stale reviews" #560
Conversation
**Why**: We believe this still meets the AC-2 control, while also allowing for a more flexible workflow for Login.gov contributors
There was a problem hiding this comment.
It's not clear to me if this file overrides everything contained in the default configuration, or is merged with it? In other words, do we need to duplicate all the other configuration values in that file?
I don't know! I'm inclined to merge it, remove the setting, and see if we get flagged for it? |
Sure 👍 I'd guess we'd need to remove some other setting we're still expecting to be enforced (like |
|
I have unchecked the box, will see if we get nagged via GitHub issue 
|
Yeah, can we confirm we haven't disabled all the rules? |
|
I tried disabling this, which should also be a policy violation, so we should get a nag about this 
|
|
Ok, no nag, so oops, this disabled everything. I'll redo this to include the full configs from the parent repo. |
Do we know if we'd expect to receive a notification immediately, or is it checked on a recurring delay? |
|
#519 Got an error, I will re-enable the "do not allow admin bypass" |
Why: We believe this still meets the AC-2 control, while also allowing for a more flexible workflow for Login.gov contributors
Based on a Slack conversation in #tts-devtools, it sounds like we might be able to override this