Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sign-in UI consistent (IE11 rendered poorly) #392

Merged
merged 3 commits into from May 19, 2020
Merged

Make sign-in UI consistent (IE11 rendered poorly) #392

merged 3 commits into from May 19, 2020

Commits on May 8, 2020

  1. Make sign-in UI consistent (IE11 rendered poorly) 

    **Why**: LG-2963
**Why**: The UI to navigate to secure.login.gov was inconsistent
**How**: Reduced markup to span > a for better accessibility
**How**: Revised CSS
    @slj
    slj committed May 8, 2020
    Copy the full SHA
    41168bb View commit details
    Browse the repository at this point in the history

  2. Moved sign-in button CSS background to style tag 

    **Why**: url needs reference to {{ site.baseurl }}
**Why**: {{ site.baseurl }} can't be referenced in CSS
    @slj
    slj committed May 8, 2020
    Copy the full SHA
    1a7525a View commit details
    Browse the repository at this point in the history

  3. Moved style back to CSS + replaced id with class 

    **Why**: The relative path can be specified in the stylesheet
**Why**: Using a classname will allow for multiple sign-in elements
    @slj
    slj committed May 8, 2020
    Copy the full SHA
    66d7c51 View commit details
    Browse the repository at this point in the history