Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments from group review #92

Merged
merged 4 commits into from
May 27, 2021
Merged

Comments from group review #92

merged 4 commits into from
May 27, 2021

Conversation

adborden
Copy link
Contributor

@adborden adborden commented May 26, 2021 •
edited
Loading

Part of GSA/datagov-ckan-multi#567
Follow up from #88

  • Expand on technical debt commends and TODOs
  • Remove harvest extension by default in tests
  • Use "new" environment by default

Aaron D Borden added 3 commits May 26, 2021 16:28
rfc
3dc0961 
- add additional context for TODOs and tech debt items identified
- remove unused environment vars in test setup, the postgres image does not
  support alternate environment settings
- only run tests on PR events to avoid duplicate tests
Remove harvest extension by default in tests
8a79a65 
Include harvest extension in tests only when required for the item under test.
Use "new" environment by default
cc07bda
@github-actions
Copy link

github-actions bot commented May 26, 2021 •
edited
Loading

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.8.10-final-0 -----------

Name Stmts Miss Cover
ckanext/datagovtheme/init.py 6 3 50%
ckanext/datagovtheme/controllers.py 21 21 0%
ckanext/datagovtheme/dynamic_menu/init.py 0 0 100%
ckanext/datagovtheme/helpers.py 372 275 26%
ckanext/datagovtheme/plugin/init.py 37 15 59%
ckanext/datagovtheme/plugin/flask_plugin.py 6 0 100%
ckanext/datagovtheme/plugin/pylons_plugin.py 6 6 0%
TOTAL 448 320 29%
Required test coverage of
=================== 12 passed, 514

@adborden adborden marked this pull request as ready for review May 27, 2021 15:10
@adborden adborden requested a review from a team May 27, 2021 16:00
@mogul mogul merged commit c85109b into main May 27, 2021
@mogul mogul deleted the feature/rfc branch May 27, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogul mogul mogul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adborden @mogul