Table: Fixed border issue #7432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: christian medders <christian.medders@gsa.gov>
clmedders
added
the
Dev: frontend
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Avoid nested selector - Use baseline alignment instead of `super` for improved readability
mejiaj
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Looks good.
I've updated alignment to baseline for readability in 5728896. It was previously set as super, but that can cause unexpected display issues - vertical-align - CSS: Cascading Style Sheets | MDN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed table styles and improved code quality and readability.
Preview
Link to Preview
Solution
Removed and updated custom table styles that were conflicting base USWDS designs.
This was found 11 times through out the site but have been checked and not major visual regressions were found but all tables are now looking like the USWDS table design.
Below is a table to compare the live site to what the tables will look like with this update.
How To Test
Dev Checklist