Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base template: <footer> #1259

Closed
2 tasks done
stvnrlly opened this issue Feb 28, 2024 · 1 comment · Fixed by #1278
Closed
2 tasks done

Base template: <footer> #1259

stvnrlly opened this issue Feb 28, 2024 · 1 comment · Fixed by #1278
Assignees

Comments

@stvnrlly
Copy link
Collaborator

stvnrlly commented Feb 28, 2024

In creating a new base template, we want to draw on general best practices along with specific TTS examples.

To complete:

  • Research <footer> elements
  • Propose the contents of the tag for team discussion
@heyitsmebev
Copy link

heyitsmebev commented Mar 6, 2024

After looking into it, I've realized that the useFooter macro might be more of an overkill than what we actually need for our setup. It introduces additional complexity and requires more files and configurations than are truly necessary. Right now, we're only using it in the admin_template and the main_template, and it doesn't provide the level of reusability that would justify its complexity and extra work.

In the current setup, useFooter is invoked in the admin_template, where it passes parameters, but this level of customization isn't utilized broadly across our project.

To simplify our footer, I have created a footer.html file within the components directory and when we are ready, we can delete the macro (components/components/footer). The new footer.html file contains all necessary links and can be easily included in our templates. With the new base.html, the need to call the footer from multiple places is eliminated, because both the main_template and admin_template will extend from base.html. This change should cut down the clutter and provide more clarity.

To include the new footer component, we can simply use {% include "new/components/footer/footer.html" %} in the base.html file.

The footer is also using TTS recommended footer practices by utilizing the Big footer component and it resizes when in mobile viewport.

@heyitsmebev heyitsmebev linked a pull request Mar 6, 2024 that will close this issue
2 tasks
ccostino added a commit that referenced this issue Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants