Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1259
Description
I was tasked to create a base template for the footer.
I've converted the footer from a macro-based approach to a single footer.html file, we now have a centralized location for all footer-related content, including links and the logo.
To QA
Uncomment line 252 in the admin_template.html. Check to see if logo, links and if it's responsive.
Changes Made
I kept a lot of the structure the same as before. I added lines 42-46 lines of code to the footer.html and moved the
<div class="usa-identifier site-identifier">
into the footer tagTODO
Notes for the future
Extra reading/context
#1259 (comment)