Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base template: <footer> #1259 #1278

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Base template: <footer> #1259 #1278

merged 2 commits into from
Mar 14, 2024

Conversation

heyitsmebev
Copy link

@heyitsmebev heyitsmebev commented Mar 6, 2024

Ticket: #1259

Description

I was tasked to create a base template for the footer.

I've converted the footer from a macro-based approach to a single footer.html file, we now have a centralized location for all footer-related content, including links and the logo.

To QA

Uncomment line 252 in the admin_template.html. Check to see if logo, links and if it's responsive.

Changes Made

I kept a lot of the structure the same as before. I added lines 42-46 lines of code to the footer.html and moved the <div class="usa-identifier site-identifier"> into the footer tag

          {% if current_service and current_service.research_mode %}
            Built by the <a href="https://www.gsa.gov/about-us/organization/federal-acquisition-service/technology-transformation-services/tts-solutions" class="usa-link">Technology Transformation Services</a><span id="research-mode" class="research-mode">research mode</span>
          {% else %}
            Built by the <a href="https://www.gsa.gov/about-us/organization/federal-acquisition-service/technology-transformation-services/tts-solutions" class="usa-link">Technology Transformation Services</a>
          {% endif %}

TODO

  • Create a base footer template
  • Responsive

Notes for the future

  • lines 179 - 251 in admin_template can all be deleted and replaced with {% include "new/components/footer/footer.html" %} when we are ready to use the new base footer template

Extra reading/context
#1259 (comment)

@heyitsmebev heyitsmebev linked an issue Mar 6, 2024 that may be closed by this pull request
2 tasks
@heyitsmebev heyitsmebev requested review from ccostino and a team March 6, 2024 20:53
Copy link
Contributor

@terrazoon terrazoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will conflict with one of my open PRs to add the GitHub version to the footer, but otherwise looks good.

@ccostino
Copy link
Contributor

@terrazoon it shouldn't conflict, at least not yet - this is a new footer file, not modifications to the existing one. :-)

That said, it's good to note this as a future change that will be needed here! @heyitsmebev, it might be easiest for us to hold on this just a bit until #1245 is fully reviewed and merged, then the changes can be incorporated here easily as well.

Does that sound good?

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @heyitsmebev!

Noting here that this file will need to incorporate the GitHub hash that @terrazoon added to our current footer, but it's not a blocker to merging this now.

@ccostino ccostino merged commit cd06337 into main Mar 14, 2024
8 checks passed
@ccostino ccostino deleted the 1259-base-template-footer branch March 14, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base template: <footer>
3 participants