Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest version commit hash to footer (notify-admin-204) #1245

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Feb 26, 2024

Description

Add the short commit hash to the footer. Note that the only way I could test this in development was to put an environment variable in my .env file like:

COMMIT_HASH=hahahaha

the line in deploy.yml is supposed to retrieve the 7 digit short commit hash.

Screenshot 2024-02-26 at 11 10 54 AM

Security Considerations

N/A

@terrazoon terrazoon self-assigned this Feb 26, 2024
@terrazoon terrazoon linked an issue Feb 26, 2024 that may be closed by this pull request
@ccostino ccostino requested a review from a team March 4, 2024 16:02
@ccostino ccostino mentioned this pull request Mar 11, 2024
2 tasks
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon! All looks good to me here, I have just one minor request for adjusting what we display in the case of noting having a commit hash available - suggestion already given! :-)

Speaking of which, I can't think of any situation where that wouldn't come through unless the git command failed for some reason, but even in that scenario I suspect that other failures would be taking place as well. Is there any situation you can think of where just that command would fail and if so, is there a fallback we need in the script to account for it so the whole thing doesn't fail?

app/config.py Outdated Show resolved Hide resolved
@terrazoon
Copy link
Contributor Author

Thanks, @terrazoon! All looks good to me here, I have just one minor request for adjusting what we display in the case of noting having a commit hash available - suggestion already given! :-)

Speaking of which, I can't think of any situation where that wouldn't come through unless the git command failed for some reason, but even in that scenario I suspect that other failures would be taking place as well. Is there any situation you can think of where just that command would fail and if so, is there a fallback we need in the script to account for it so the whole thing doesn't fail?

I think the dashes are enough. Obviously we don't want it to fail so if we see dashes on staging, will have to debug there.

@terrazoon terrazoon requested a review from ccostino March 13, 2024 18:32
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

@ccostino ccostino merged commit 4dc442c into main Mar 14, 2024
8 checks passed
@ccostino ccostino deleted the notify-admin-204 branch March 14, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make deployed version visible in builds
2 participants