-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latest version commit hash to footer (notify-admin-204) #1245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @terrazoon! All looks good to me here, I have just one minor request for adjusting what we display in the case of noting having a commit hash available - suggestion already given! :-)
Speaking of which, I can't think of any situation where that wouldn't come through unless the git
command failed for some reason, but even in that scenario I suspect that other failures would be taking place as well. Is there any situation you can think of where just that command would fail and if so, is there a fallback we need in the script to account for it so the whole thing doesn't fail?
I think the dashes are enough. Obviously we don't want it to fail so if we see dashes on staging, will have to debug there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @terrazoon!
Description
Add the short commit hash to the footer. Note that the only way I could test this in development was to put an environment variable in my .env file like:
COMMIT_HASH=hahahaha
the line in deploy.yml is supposed to retrieve the 7 digit short commit hash.
Security Considerations
N/A